chore(ci): harden arch check and import hygiene — unblock branch CI#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the architecture boundary check portable on runners without
rgand cleans up a small set of remaining absolute-path references in the core runtime/host code. This matters because the samearch-checkfailure can block every open PR regardless of branch-specific logic, and the import cleanup keeps the runtime code aligned with the contribution standards the project expects.Changes
scripts/arch-check.sh: route forbidden-import checks through the existing search helper and fix thergargument order so the script works with or withoutrginstalledcrates/sof-observer/src/framework/host.rs: importTxCommitmentStatusandTransactionDispatchMode, usethread::available_parallelism(), and remove inline absolute-path references from plugin hook subscription setupcrates/sof-observer/src/runtime.rs: import kernel-bypass queue types/helpers andthread, then replace remaining obvious absolute-path calls in the public runtime surfaceapp/runtime,frameworkMotivation
Business motivation:
cargo make arch-checkon a runner image withoutrg.Technical motivation:
crate::...andstd::...references in hot-path runtime code.Alternative approaches considered:
rgin CI instead of hardening the script. That keeps the script brittle for developers and other runners, so I rejected it.Scope and impact
framework,app/runtimearch-check; no runtime behavior changeTesting
Commands/results:
cargo make arch-check cargo test -p sof --lib --no-run cargo fmt --check --allAll commands passed locally.
Related issues and documentation
#89,#91,#92) depends on this shared CI portability fixdocs/architecture/README.mddocs/architecture/ard/0001-project-structure-and-code-goals.md,docs/architecture/ard/0003-slice-dependency-contracts.mdReviewer checklist
docs/architecture/ard/0003-slice-dependency-contracts.md)Additional notes
main.